Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the custom run keyboard shortcut #6303

Merged
merged 1 commit into from
Mar 9, 2022

Conversation

jtpio
Copy link
Member

@jtpio jtpio commented Mar 8, 2022

Fixes jupyterlab/retrolab#332

Since Notebook v7 now depends on the latest JupyterLab 4.0 pre-release which includes this shortcut by default.

@jtpio jtpio added this to the 7.0 milestone Mar 8, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Mar 8, 2022

Binder 👈 Launch a Binder on branch jtpio/notebook/cleanup-shortcut

@jtpio jtpio marked this pull request as ready for review March 9, 2022 07:44
@jtpio
Copy link
Member Author

jtpio commented Mar 9, 2022

If someone with a Mac wants to quickly check both the Cmd Enter and Ctrl Enter shortcuts run the current cell without advancing: https://mybinder.org/v2/gh/jtpio/notebook/cleanup-shortcut?urlpath=tree

Copy link
Member

@blink1073 blink1073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified on MacOS, thanks!

@blink1073 blink1073 merged commit 4959617 into jupyter:main Mar 9, 2022
@jtpio jtpio deleted the cleanup-shortcut branch March 9, 2022 12:25
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 6, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove custom runShortcut plugin
2 participants