Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update further to ipykernel comm refactoring #6358

Merged
merged 3 commits into from
Apr 12, 2022

Conversation

echarles
Copy link
Member

This aims to fix the reported failing test on https://github.com/jupyter/notebook/runs/5984992147?check_suite_focus=true

It just changes the needed imports to fit the latest and correct ipykernel package.

FAIL failed_restart: 3 events were triggered
#    type: assertEquals
#    file: /home/runner/work/notebook/notebook/notebook/tests/services/kernel.js
#    subject: 0
#    expected: 3
Test file: /home/runner/work/notebook/notebook/notebook/tests/services/serialize.js
PASS Created echo comm target
FAIL Error running cell:
---------------------------------------------------------------------------
ModuleNotFoundError                       Traceback (most recent call last)
Input In [1], in <cell line: 2>()
```

@echarles echarles marked this pull request as draft April 12, 2022 10:11
@echarles
Copy link
Member Author

@blink1073 This produces more successful tests on the CI.

@echarles echarles marked this pull request as ready for review April 12, 2022 10:42
@echarles echarles added this to the 6.4 milestone Apr 12, 2022
@echarles echarles added the bug label Apr 12, 2022
Copy link
Member

@blink1073 blink1073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@echarles echarles merged commit 3911672 into jupyter:6.4.x Apr 12, 2022
@echarles
Copy link
Member Author

Thx @blink1073

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants