Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add the show header command to the command palette #6415

Merged
merged 1 commit into from
May 3, 2022
Merged

add the show header command to the command palette #6415

merged 1 commit into from
May 3, 2022

Conversation

jeewonkoo
Copy link

  • Added ICommandPalette to the list of optional
  • Added if (palette) { palette.addItem({ command: CommandIDs.toggleTop, category: 'View' }); } to add the command to the palette
  • Added palette: ICommandPalette | null to activate

@github-actions
Copy link
Contributor

github-actions bot commented May 3, 2022

Binder 👈 Launch a Binder on branch jeewonkoo/notebook/develop

@jtpio jtpio added this to the 7.0 milestone May 3, 2022
jtpio
jtpio approved these changes May 3, 2022
View reviewed changes
Copy link
Member

@jtpio jtpio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Looks good on Binder:

image

@jeewonkoo
Copy link
Author

Glad it worked well!

@jtpio jtpio merged commit 9cde2b6 into jupyter:main May 3, 2022
@jtpio jtpio mentioned this pull request May 3, 2022
Closed
@afshin afshin mentioned this pull request May 5, 2022
Closed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jtpio jtpio jtpio approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
7.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jeewonkoo @jtpio