Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix tests #6464

Merged
merged 4 commits into from
Jul 5, 2022
Merged

Fix tests #6464

merged 4 commits into from
Jul 5, 2022

Conversation

jtpio
Copy link
Member

@jtpio jtpio commented Jul 5, 2022

Tests have started failing with the latest tornado release which deprecates: https://www.tornadoweb.org/en/stable/releases/v6.2.0.html#deprecation-notice

The IOLoop constructor is deprecated unless the make_current=False argument is used. Use IOLoop.current when the loop is already running instead.

Example run: https://github.com/jupyter/notebook/runs/7191744285?check_suite_focus=true

This PR attempts at fixing it.

@jtpio jtpio added this to the 7.0 milestone Jul 5, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Jul 5, 2022

Binder 👈 Launch a Binder on branch jtpio/notebook/ci

@jtpio jtpio marked this pull request as ready for review July 5, 2022 08:12
@jtpio
Copy link
Member Author

jtpio commented Jul 5, 2022

Marking as ready for now.

Looks like the proper fix would be for pytest-tornasync to fix these warnings at some point: https://github.com/eukaryote/pytest-tornasync

@jtpio jtpio merged commit a3d20ad into jupyter:main Jul 5, 2022
@jtpio jtpio deleted the ci branch July 5, 2022 13:09
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
maintenance
Projects
None yet
Milestone
7.0
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@jtpio