Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Explicitly specify favicon for /tree view in Notebook #6608

Merged
merged 1 commit into from
Nov 14, 2022
Merged

Explicitly specify favicon for /tree view in Notebook #6608

merged 1 commit into from
Nov 14, 2022

Conversation

mcrutch
Copy link
Contributor

@mcrutch mcrutch commented Oct 31, 2022

This is instead of relying on /favicon.ico resolving to the correct artifact

Closes #6607

@mcrutch
Explicitly specify favicon for /tree view in Notebook rather than rel…
487a303 
…y on /favicon.ico resolving to the correct artifact
@github-actions
Copy link
Contributor

Binder 👈 Launch a Binder on branch mcrutch/notebook/specify-favicon-on-tree

@jtpio jtpio added the bug label Nov 14, 2022
@jtpio jtpio added this to the 7.0 milestone Nov 14, 2022
jtpio
jtpio approved these changes Nov 14, 2022
View reviewed changes
Copy link
Member

@jtpio jtpio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jtpio jtpio merged commit 418c7e2 into jupyter:main Nov 14, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jtpio jtpio jtpio approved these changes

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
7.0
Development

Successfully merging this pull request may close these issues.

favicon not explicitly specified for /tree (Notebook v7)
2 participants
@mcrutch @jtpio