Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moves panel related objects to a dedicated module file #6625

Merged
merged 1 commit into from
Nov 18, 2022

Conversation

brichet
Copy link
Contributor

@brichet brichet commented Nov 17, 2022

This PR fixes #6557 by moving all the panel related objects from application/shell.ts to application/panelhandler.ts.

The panelhandler.ts module includes the PanelHandler, the SidePanelHandler and the SidePanelPalette classes.
For consistency it also renames all code occurrences of sidebar to sidePanel.

@github-actions
Copy link
Contributor

Binder 👈 Launch a Binder on branch brichet/notebook/sidepanel_followup

@jtpio jtpio added this to the 7.0 milestone Nov 17, 2022
Copy link
Member

@jtpio jtpio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jtpio jtpio merged commit beba237 into jupyter:main Nov 18, 2022
@brichet brichet deleted the sidepanel_followup branch December 28, 2022 13:25
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Side panel follow-ups
2 participants