Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sys_info to page template for 6.5.x #6668

Merged
merged 1 commit into from Dec 21, 2022
Merged

Conversation

juhasch
Copy link
Contributor

@juhasch juhasch commented Dec 20, 2022

This PR is to allow to infer the current notebook version using sys_info.notebook_version in a legacy notebook extension, when using the page.html template. This is similar to how it is done in the notebook.html template.

Use case is the nbextensions overview tab, where a compatibility check for the notebook version is performed.
As Jupyter.version no longer works, it should be replaced by sys_info.notebook_version here: PR.

@echarles : What do you think ?

Copy link
Member

@echarles echarles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Thx @juhasch

@echarles echarles merged commit 8773864 into jupyter:6.5.x Dec 21, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants