Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

File browser CSS tweaks #6738

Merged
merged 7 commits into from
Feb 20, 2023
Merged

File browser CSS tweaks #6738

merged 7 commits into from
Feb 20, 2023

Conversation

jtpio
Copy link
Member

@jtpio jtpio commented Feb 17, 2023

Iterations towards #6397

Fixes #6730.

Some tyling adjustments to the file browser to it looks more similar to the classic notebook:

  • Reduce the width of the tabs
  • Remove the drop shadow for the file browser
  • Style some buttons

Before

image

After

image

Classic Notebook

image

@jtpio jtpio added this to the 7.0 milestone Feb 17, 2023
@github-actions
Copy link
Contributor

Binder 👈 Launch a Binder on branch jtpio/notebook/filebrowser-styling

@jtpio jtpio force-pushed the filebrowser-styling branch 3 times, most recently from f26f59b to 0c128d1 Compare February 17, 2023 14:47
@jtpio
Copy link
Member Author

jtpio commented Feb 17, 2023

bot please update playwright snapshots

@jtpio jtpio closed this Feb 17, 2023
@jtpio jtpio reopened this Feb 17, 2023
@jtpio jtpio marked this pull request as ready for review February 17, 2023 18:10
@jtpio
Copy link
Member Author

jtpio commented Feb 20, 2023

Looking good on Binder.

This can be iterated on in follow-up PRs.

@jtpio jtpio merged commit e7b5c37 into jupyter:main Feb 20, 2023
@jtpio jtpio deleted the filebrowser-styling branch February 20, 2023 08:26
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Styling regressions in Notebook 7 tab bar
1 participant