Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix import of warnings.warn #6840

Merged
merged 2 commits into from
Apr 24, 2023
Merged

fix import of warnings.warn #6840

merged 2 commits into from
Apr 24, 2023

Conversation

minrk
Copy link
Member

@minrk minrk commented Apr 17, 2023

warn was never part of the traitlets API, and changed in ipython/traitlets#838

never part of the traitlets API
@minrk minrk added the bug label Apr 17, 2023
@jtpio
Copy link
Member

jtpio commented Apr 24, 2023

cc @RRosio @echarles

Copy link
Member

@echarles echarles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@echarles echarles merged commit fa1f3e4 into jupyter:6.4.x Apr 24, 2023
9 of 36 checks passed
holzman pushed a commit to holzman/notebook that referenced this pull request Sep 14, 2023
* fix import of warnings.warn

never part of the traitlets API

* remove yanked codecov
@minrk minrk deleted the 6.4.x branch September 15, 2023 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants