Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix playwright bot #6880

Merged
merged 21 commits into from May 25, 2023
Merged

Fix playwright bot #6880

merged 21 commits into from May 25, 2023

Conversation

jtpio
Copy link
Member

@jtpio jtpio commented May 18, 2023

Fixes #6859

@jtpio
Copy link
Member Author

jtpio commented May 18, 2023

bot please update playwright snapshots

@github-actions
Copy link
Contributor

Binder 👈 Launch a Binder on branch jtpio/notebook/fix-playwright-bot

@jtpio jtpio added this to the 7.0 milestone May 18, 2023
@jtpio
Copy link
Member Author

jtpio commented May 18, 2023

bot please update playwright snapshots

@jtpio
Copy link
Member Author

jtpio commented May 22, 2023

So it looks like it was an issue with different yarn versions being used:

jupyterlab/maintainer-tools#196 should help address this.

@jtpio jtpio marked this pull request as ready for review May 25, 2023 09:58
@jtpio
Copy link
Member Author

jtpio commented May 25, 2023

jupyterlab/maintainer-tools#196 should help address this.

jupyterlab/maintainer-tools#196 has been merged and released, so we should be able to try it in a separate PR.

@jtpio jtpio merged commit 78ad211 into jupyter:main May 25, 2023
25 checks passed
@jtpio jtpio deleted the fix-playwright-bot branch May 25, 2023 11:42
@andrii-i
Copy link
Contributor

Thank you for taking care of this @jtpio. Please feel free to request PR reviews from me if/when needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Bot please update playwright snapshots" doesn't work
2 participants