Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove viewport workaround in the UI tests #6887

Merged
merged 5 commits into from Dec 13, 2023
Merged

Remove viewport workaround in the UI tests #6887

merged 5 commits into from Dec 13, 2023

Conversation

jtpio
Copy link
Member

@jtpio jtpio commented May 25, 2023 •
edited

Fixes #6553

@github-actions
Copy link
Contributor

Binder 👈 Launch a Binder on branch jtpio/notebook/fix-viewport-tests

@jtpio jtpio added this to the 7.0 milestone May 26, 2023
@jtpio jtpio mentioned this pull request May 30, 2023
Merged
4 tasks
jtpio
jtpio commented Jun 7, 2023
View reviewed changes
ui-tests/test/mobile.spec.ts Outdated Show resolved Hide resolved
@jtpio jtpio mentioned this pull request Jun 7, 2023
Merged
4 tasks
@jtpio
Copy link
Member Author

jtpio commented Jun 7, 2023

Looks like the toolbar items are visible, but some are cropped:

image

@jtpio jtpio mentioned this pull request Jun 9, 2023
Closed
@andrii-i andrii-i modified the milestones: 7.0, 7.1, 7.0.x Jun 12, 2023
@jtpio jtpio closed this Dec 13, 2023
@jtpio jtpio reopened this Dec 13, 2023
@jtpio jtpio marked this pull request as ready for review December 13, 2023 15:53
@jtpio
Copy link
Member Author

jtpio commented Dec 13, 2023

For some reasons, rebasing on the latest main makes the test pass.

It could be because the issue was fixed in a JupyterLab 4.1 pre-release.

@jtpio jtpio merged commit c2ca209 into jupyter:main Dec 13, 2023
61 checks passed
@jtpio jtpio deleted the fix-viewport-tests branch December 13, 2023 15:58
@jtpio jtpio modified the milestones: 7.0.x, 7.1 Dec 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jtpio jtpio

Labels
maintenance
Projects
None yet
Milestone
7.1.0
Development

Successfully merging this pull request may close these issues.

Toolbar is often empty when opening a Notebook
2 participants
@jtpio @andrii-i