Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Configurable default_url for JupyterNotebookApp #6899

Merged
merged 1 commit into from Jun 5, 2023
Merged

Configurable default_url for JupyterNotebookApp #6899

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 3 additions & 3 deletions notebook/app.py
View file
Open in desktop
Expand Up @@ -19,7 +19,7 @@
from jupyterlab_server.handlers import _camelCase, is_url
from notebook_shim.shim import NotebookConfigShimMixin # type:ignore
from tornado import web
from traitlets import Bool, default
from traitlets import Bool, Unicode, default

from ._version import __version__

Expand Down Expand Up @@ -120,7 +120,7 @@ class RedirectHandler(NotebookBaseHandler):
@web.authenticated
def get(self):
"""Get the redirect url."""
return self.redirect(self.base_url + "tree")
return self.redirect(self.base_url.strip("/") + "/" + self.default_url.strip("/"))


class TreeHandler(NotebookBaseHandler):
Expand Down Expand Up @@ -215,7 +215,7 @@ class JupyterNotebookApp(NotebookConfigShimMixin, LabServerApp):
version = version
app_version = version
extension_url = "/"
default_url = "/tree" # type:ignore
default_url = Unicode("/tree", config=True, help="The default URL to redirect to from `/`")
file_url_prefix = "/notebooks"
load_other_extensions = True
app_dir = app_dir
Expand Down