Add an empty splash screen on notebook launch to avoid a flash of unstyled content #6911
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
andrii-i
commented
Jun 9, 2023
| activate: (app: JupyterFrontEnd) => { | ||
| const { restored } = app; | ||
| const splash = document.createElement('div'); | ||
| splash.style.position = 'absolute'; |
There was a problem hiding this comment.
Styling has to be inline or it does not load through on time
jtpio
reviewed
Jun 9, 2023
|
Thank you @jtpio |
jitseniesen
added a commit
to jitseniesen/spyder-notebook
that referenced
this pull request
Jun 29, 2023
This was added in PR jupyter/notebook#6911
jitseniesen
added a commit
to jitseniesen/spyder-notebook
that referenced
this pull request
Jul 22, 2023
This was added in PR jupyter/notebook#6911
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add an empty splash screen on notebook launch to avoid a flash of unstyled content while custom CSS is loading.
Fixes #6790.
Without this PR:
(slowed down)
With this PR:
(slowed down)
