Fix default viewers override #6923
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Still troubleshooting this. |
|
Looking better: jupytext-default-viewer.mp4Although not sure why there is no toolbar when opening the markdown file with the default-viewers-jupytext-jupyterlab.mp4 |
|
cc @parmentelat for awareness, since this PR should already help in case you would like to try it out. As noted above, it seems like there is an issue with the toolbar even with JupyterLab. Maybe this could be addressed as part of the JupyterLab 4 compatibility happening in mwouts/jupyterlab-jupytext#3 |
jtpio
commented
Jun 16, 2023
| const urlParams = new URLSearchParams(parsed.search); | ||
| let defaultFactory = docRegistry.defaultWidgetFactory(path).name; | ||
|
|
||
| // Explicitely get the default viewers from the settings because |
There was a problem hiding this comment.
Maybe we can track that in a JupyterLab issue so it can be discussed.
|
Thanks @andrii-i for the review! Just rebased and CI all green ✔️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Troubleshooting #6914
Notebook 7 should respect the
defaultViewerssettings overrides when opening a document.Testing with Jupytext with the following:
pip install jupytextpip install git+https://github.com/mwouts/jupyterlab-jupytext.git@jupyterlab4