Improve about dialog #6996
Merged
Improve about dialog #6996
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
More Suggestions for Improving about dialog UII have other modifications to show to improve the about dialog. |
|
Thanks @yjrab! Would it be possible to provide a before / after screenshot of the changes so it's easier to have an idea of the visual changes? |
|
Hi @jtpio, yes absolutely! The following image is the Jupyter Notebook About Dialog Before: The following image is the Jupyter Notebook About Dialog After: The following image is the Jupyter Lab About Dialog used as reference: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggestions for Improving about dialog UI
This is to make Jupyter Notebook's about dialog UI similar to that of Jupyter Lab's.
This is related to issue: Improve the About dialog #6552
Modifications in base.css for .jp-AboutNotebook-version
To make sure that the spacing between the version line and external link is bigger than before and closer to how it is in Jupyter Lab. More importantly, to make sure that the default dialog box when first opened has the same height and width as the dialog box in Jupyter Lab.
Modifications in base.css for .jp-AboutNotebook-about-externalLinks
To make sure that the spacing around the external links are consistent with how it is in Jupyter Lab.
- padding-top: 12px;