Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Edit Notebook Metadata Option (#6402) #7099

Merged
merged 21 commits into from Feb 7, 2024

Conversation

Dilip-Jain
Copy link
Contributor

@Dilip-Jain Dilip-Jain commented Oct 9, 2023

Issue No. #6402

Problem

Feature Required: Edit Notebook Metadata option under the Edit Menu (in Notebook) as was in classic notebook.
@jtpio mentions -

Maybe the simplest way for now would be to add a Edit Notebook Metadata command to the menu that would open the Notebook tools panel instead of a dialog.

Solution

Edit Notebook Metadata plugin added under Edit Menu for functionality similar to classic-notebook. Clicking on the option under the menu opens up the Notebook Tools widget in the right sidebar and expands the Additional Tools (which contains the Notebook Metadata editor) collapsible section (default: collapsed).
Fixes #6402

Key Addition [Enhancement]

editNotebookMetadata plugin to add a command to open right sidebar for Editing Notebook Metadata when clicking on "Edit Notebook Metadata" option under Edit menu.

  • On the click, the plugin first checks if Show Notebook Tools (Right Sidebar) is open (expanded)
  • If not open, toggle the Right Sidebar and expand the Show Notebook Tools.
  • Lastly, it expands the 'Advanced Tools' collapsible section (default, collapsed)

Thank you for considering this pull request, and I welcome any feedback or suggestions for further improvements.

Edit Notebook Metadata plugin added under Edit Menu for functionality similar to classic-notebook.
Clicking on the option under the menu opens up the Notebook Tools widget in the right sidebar and expands the Additional Tools (which contains the Notebook Metadata editor) collapsible section (default: collapsed).
@github-actions
Copy link
Contributor

github-actions bot commented Oct 9, 2023

Binder 👈 Launch a Binder on branch Dilip-Jain/notebook/edit-notebook-metadata

@Dilip-Jain
Copy link
Contributor Author

Dilip-Jain commented Oct 26, 2023

Hey @jtpio,
anything not in place or needs to be altered?
just created another PR for (different) issue 7008, so just checkin' in here..

@jtpio jtpio added this to the 7.1 milestone Oct 27, 2023
@jtpio
Copy link
Member

jtpio commented Feb 7, 2024

FYI @Dilip-Jain I pushed a few commits to fix the menu item, and add the command to the command palette.

@jtpio
Copy link
Member

jtpio commented Feb 7, 2024

bot please update playwright snapshots

Copy link
Member

@jtpio jtpio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jtpio jtpio merged commit 2d717f5 into jupyter:main Feb 7, 2024
31 checks passed
@Dilip-Jain Dilip-Jain deleted the edit-notebook-metadata branch February 7, 2024 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Edit notebook metadata
2 participants