Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to JupyterLab 4.1.5 packages #7291

Merged
merged 5 commits into from Mar 14, 2024
Merged

Update to JupyterLab 4.1.5 packages #7291

merged 5 commits into from Mar 14, 2024

Conversation

jtpio
Copy link
Member

@jtpio jtpio commented Mar 8, 2024

No description provided.

Copy link
Contributor

github-actions bot commented Mar 8, 2024

Binder 👈 Launch a Binder on branch jtpio/notebook/updates

@jtpio
Copy link
Member Author

jtpio commented Mar 8, 2024

Seeing the following behavior with the notebook toolbar items, which might be new:

notebook-7-toolbar-items.webm

While on the previous version this seems to be fine:

notebook-7-toolbar-items-711.webm

@jtpio jtpio added this to the 7.1.x milestone Mar 8, 2024
@jtpio
Copy link
Member Author

jtpio commented Mar 8, 2024

Seeing the following behavior with the notebook toolbar items, which might be new:

cc @brichet could this be related to jupyterlab/jupyterlab#15843?

@jtpio
Copy link
Member Author

jtpio commented Mar 8, 2024

This is also caught by the UI tests, with some tests timing out because the debugger button is not visible:

image

@brichet
Copy link
Contributor

brichet commented Mar 8, 2024

@jtpio It is probably related to the PR you mentioned, but I don't know why yet.
There is also an error in the console:

@brichet
Copy link
Contributor

brichet commented Mar 8, 2024

@jtpio
Copy link
Member Author

jtpio commented Mar 8, 2024

Maybe it's related to the interface switcher extension from https://github.com/jupyter/notebook/blob/main/packages/lab-extension/src/index.ts (I think that would be the main difference between lab and notebook for the notebook toolbar). Although this one should go through the regular toolbar system via the settings normally.

@brichet
Copy link
Contributor

brichet commented Mar 8, 2024

Maybe it's related to the interface switcher extension from https://github.com/jupyter/notebook/blob/main/packages/lab-extension/src/index.ts (I think that would be the main difference between lab and notebook for the notebook toolbar). Although this one should go through the regular toolbar system via the settings normally.

I tried to disabled it but have the same issue. But I agree it seems to be the only widget added AFAIK.

@jtpio
Copy link
Member Author

jtpio commented Mar 8, 2024

Also this does not seem to be an issue with JupyterLab when testing from this PR (JupyterLab also shows the interface switcher widget in the notebook toolbar).

@brichet
Copy link
Contributor

brichet commented Mar 8, 2024

Also this does not seem to be an issue with JupyterLab when testing from this PR (JupyterLab also shows the interface switcher widget in the notebook toolbar).

I think I found the culprit on Jupyterlab, probably this call

If we replace void this._onResize(); with void this._resizer.invoke(); it works well.

My understanding is that the toolbar is rendered more quickly in Notebook than in Jupyterlab (probably because there is less to render).
Therefore this function is called for each items added to the toolbar at load time, which cause confusion in the computation of the widget to display or not in the toolbar. If we display the widgets (to compute) in console before this line some of them are undefined.

This does not occur with the fix above.

I'll open a PR on Jupyterlab.

@jtpio
Copy link
Member Author

jtpio commented Mar 8, 2024

Cool, thanks for investigating this!

@jtpio
Copy link
Member Author

jtpio commented Mar 14, 2024

CI now passing with the fix shipped in JupyterLab 4.1.5. Thanks @brichet!

@jtpio jtpio changed the title Update to JupyterLab 4.1.4 packages Update to JupyterLab 4.1.5 packages Mar 14, 2024
@jtpio jtpio marked this pull request as ready for review March 14, 2024 18:31
@jtpio jtpio merged commit ca41222 into jupyter:main Mar 14, 2024
32 checks passed
@jtpio jtpio deleted the updates branch March 14, 2024 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants