Update @jupyterlab/galata
#7361
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
bot please update playwright snapshots |
jtpio
commented
May 14, 2024
| @@ -29,7 +29,7 @@ repos: | |||
| rev: 'v2.2.6' | |||
| hooks: | |||
| - id: codespell | |||
| args: ['-L', 'hart,noteable'] | |||
| args: ['-L', 'hart,noteable', '--skip', "*.spec.ts"] | |||
There was a problem hiding this comment.
Looks like afterAll makes the pre-commit check fail: https://results.pre-commit.ci/run/github/33653601/1715676598.F47qygP7RKuJagZupcWLmA
Adding afterAll to the list of ignored words (via -L) does not seem to help, but skipping all .spec.ts files does. Might be worth investigating more in a separate issue or PR.
We can track that in a separate issue. |
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update
@jupyterlab/galatato match the latest JupyterLab 4.2.0 release.Might need some tricks from jupyterlab/jupyterlab#15621
Also make some changes to try to reduce the UI tests flakyness.