Merge pull request #368 from impact27/non_executing_scrolling

Scroll when adding text even when not executing
jupyter · Aug 27, 2019 · 4842ace · 4842ace
2 parents 9d0ffb6 + d48e37e
commit 4842ace
Showing 1 changed file with 6 additions and 7 deletions.
diff --git a/qtconsole/console_widget.py b/qtconsole/console_widget.py
@@ -2018,12 +2018,11 @@ def _insert_plain_text(self, cursor, text, flush=False):
         if buffer_size > 0:
             text = self._get_last_lines(text, buffer_size)
 
-        if self._executing:
-            viewport = self._control.viewport()
-            end_scroll_pos = self._control.cursorForPosition(
-                QtCore.QPoint(viewport.width()-1, viewport.height()-1)
-                ).position()
-            end_doc_pos = self._get_end_pos()
+        viewport = self._control.viewport()
+        end_scroll_pos = self._control.cursorForPosition(
+            QtCore.QPoint(viewport.width()-1, viewport.height()-1)
+            ).position()
+        end_doc_pos = self._get_end_pos()
 
         cursor.beginEditBlock()
         if self.ansi_codes:
@@ -2085,7 +2084,7 @@ def _insert_plain_text(self, cursor, text, flush=False):
             cursor.insertText(text)
         cursor.endEditBlock()
 
-        if self._executing and end_doc_pos - end_scroll_pos <= 1:
+        if end_doc_pos - end_scroll_pos <= 1:
             end_scroll = (self._control.verticalScrollBar().maximum()
                           - self._control.verticalScrollBar().pageStep())
             # Only scroll down