Skip to content

Commit

Permalink
Don't call processEvents when showing input prompts on Mac
Browse files Browse the repository at this point in the history
- That's not necessary on that platform
- This also fixes our test suite hanging for Mac on CIs.
  • Loading branch information
ccordoba12 committed Aug 27, 2022
1 parent e659a04 commit e3a8b5c
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 5 deletions.
5 changes: 1 addition & 4 deletions .github/workflows/macos-tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,4 @@ jobs:
conda list
- name: Run tests
shell: bash -l {0}
run: |
# Disable tests for now because they hang completely
# pytest -x -vv --cov=qtconsole qtconsole
exit 0
run: pytest -x -vv --cov=qtconsole qtconsole
3 changes: 2 additions & 1 deletion qtconsole/console_widget.py
Original file line number Diff line number Diff line change
Expand Up @@ -2483,7 +2483,8 @@ def _show_prompt(self, prompt=None, html=False, newline=True,
# This is necessary to solve out-of-order insertion of mixed stdin and
# stdout stream texts.
# Fixes spyder-ide/spyder#17710
QtCore.QCoreApplication.processEvents()
if not sys.platform == 'darwin':
QtCore.QCoreApplication.processEvents()

cursor = self._get_end_cursor()

Expand Down

0 comments on commit e3a8b5c

Please sign in to comment.