use is_complete request to indicate complete input #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| kc = self.kernel_client | ||
| if kc is None: | ||
| return | ||
| from jupyter_client import BlockingKernelClient |
There was a problem hiding this comment.
Should this be a regular import rather than a local one? jupyter_client is a plain dependency.
There was a problem hiding this comment.
regular, this was just lazy hacking as I was figuring it out.
|
Thanks for getting round to this. |
|
Thanks for reviewing - I had this mostly put together when we last talked about it a few weeks ago, but forgot about it. Thanks for reviewing. I think I did things a few different ways, and there are likely a couple of redundant bits in here, still. I'll give it another pass tomorrow. |
minrk
force-pushed
the
is_complete_2
branch
2 times, most recently
from
1623e61
to
6851c89
Compare
|
Okay, review should be addressed. Some redundant bits from earlier attempts have been removed. indent from is_complete_reply is used now, instead of hardcoded value. |
| @@ -57,6 +57,7 @@ def gui_excepthook(exctype, value, tb): | |||
| ) | |||
|
|
|||
| from jupyter_core.application import JupyterApp | |||
| from jupyter_client import BlockingKernelClient | |||
instead of IPython InputSplitter
takluyver
added a commit
that referenced
this pull request
Jul 2, 2015
use is_complete request to indicate complete input
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
instead of IPython InputSplitter.
Adds a BlockingKernelClient to perform the is_complete_request, since the current use of
_is_completecan't easily be made async.based on #19