Fix compatibility with PySide2 on Python 2.7 #280
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…en if the loaded API was PySide2
|
For some reason this only manifests itself on Python 2.7 though, and it works fine on Python 3.6, which suggests maybe somehow the forbidding isn't working quite right on Python 3.6? |
|
Yep, it certainly looks like it was just a typo. It could well be that the import denier stuff doesn't work right in Python 3.6 - it's hard to test. It's probably more important to fix the copy in IPython, because that's what runs in the kernel, denying imports for user code. |
This was referenced May 1, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a bug in commit_api which caused PySide2 binding to be forbidden even if the loaded API was PySide2 (I think it was just a typo in the if statement)