Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PR: Remove common prefix from path completions #361

Merged
merged 3 commits into from
Mar 2, 2020
Merged

PR: Remove common prefix from path completions #361

merged 3 commits into from
Mar 2, 2020

Conversation

dalthviz
Copy link
Collaborator

@dalthviz dalthviz commented Aug 9, 2019 •
edited
Loading

Fixes #358

A preview:

c

TODO:

  • Handle quoted paths (check IPython)

@ccordoba12 ccordoba12 modified the milestone: 4.5.3 Aug 9, 2019
@ccordoba12 ccordoba12 added this to the 4.6.1 milestone Jan 24, 2020
@ccordoba12
Copy link
Collaborator

@dalthviz, please solve the merge conflict here and try to finish this one.

@ccordoba12 ccordoba12 modified the milestones: 4.7.0, 4.7.1 Feb 29, 2020
ccordoba12
ccordoba12 approved these changes Mar 2, 2020
View reviewed changes
Copy link
Collaborator

@ccordoba12 ccordoba12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks @dalthviz!

@ccordoba12 ccordoba12 merged commit ba21a4a into jupyter:master Mar 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ccordoba12 ccordoba12 ccordoba12 approved these changes

Assignees

@dalthviz dalthviz

Labels
None yet
Projects
None yet
Milestone
4.7.1
Development

Successfully merging this pull request may close these issues.

Improve path completion options display
2 participants
@dalthviz @ccordoba12