Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Access cursor enums via base class #561

Merged
merged 1 commit into from
Nov 1, 2022

Conversation

mborgerson
Copy link
Contributor

Resolves some PySide6 6.4.0 compatibility issues and follows enum usage conventions used elsewhere in the code base.

@ccordoba12 ccordoba12 added this to the 5.4.0 milestone Oct 21, 2022
@ccordoba12
Copy link
Collaborator

Hey @mborgerson, thanks a lot for your contribution! It seems your changes are breaking PyQt6? I'm not really sure why, but those are the only tests that don't pass.

@mborgerson
Copy link
Contributor Author

mborgerson commented Oct 21, 2022

Hey @mborgerson, thanks a lot for your contribution! It seems your changes are breaking PyQt6? I'm not really sure why, but those are the only tests that don't pass.

Hi @ccordoba12. Thanks for the quick review. I took a look at the failure. This test failure appears to be caused by a bug in Qt 6.4.0, which is unrelated to this patch and also causing test failure on master branch. The bug is present in both pyside/pyqt, and appears to have been fixed for next release in their issue tracker.

@ccordoba12
Copy link
Collaborator

Thanks a lot for pointing that out @mborgerson! I fixed our tests in PR #562, so please rebase this one so I can merge it.

@mborgerson
Copy link
Contributor Author

Thanks a lot for pointing that out @mborgerson! I fixed our tests in PR #562, so please rebase this one so I can merge it.

Done

Copy link
Collaborator

@ccordoba12 ccordoba12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution @mborgerson!

@ccordoba12 ccordoba12 merged commit 022c845 into jupyter:master Nov 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants