Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'Repo2Docker' object has no attribute ‘debug' #563

Closed
jhamman opened this issue Jan 25, 2019 · 4 comments
Closed

'Repo2Docker' object has no attribute ‘debug' #563

jhamman opened this issue Jan 25, 2019 · 4 comments

Comments

@jhamman
Copy link
Contributor

jhamman commented Jan 25, 2019

As reported by @sbinet,

When repo2docker raises an error, it is possible to get the following message on the command line:

'Repo2Docker' object has no attribute ‘debug'

This seems to come from this section:

https://github.com/jupyter/repo2docker/blob/ff894f4404a9abcbb5163f638f952a1ba89fe8b3/repo2docker/__main__.py#L335-L344

I am not sure exactly how the configuration system works here but I notice this is the only time the debug argument is accessed:

https://github.com/jupyter/repo2docker/blob/ff894f4404a9abcbb5163f638f952a1ba89fe8b3/repo2docker/__main__.py#L220-L221

cc @betatim who thought this also looked like a bug

@yuvipanda
Copy link
Collaborator

I think I missed adding a 'debug' boolean traitlet to repo2docker.app when I did some refactoring...

@betatim
Copy link
Member

betatim commented Feb 3, 2019

Yuvi, can you please make a PR that sets app.debug to true when the logging level is high enough?

yuvipanda added a commit to yuvipanda/repo2docker that referenced this issue Feb 7, 2019
@yuvipanda
Copy link
Collaborator

@betatim done #575

@jhamman
Copy link
Contributor Author

jhamman commented Feb 8, 2019

Thanks @yuvipanda!!!

markmo pushed a commit to markmo/repo2docker that referenced this issue Jan 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants