Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updates for Stencila #457
Updates for Stencila #457
Changes from 8 commits
24def16
9624f0f
8342fbd
3a479b6
da41a90
7e8450f
6d30417
3f4da20
a57a443
8d9a487
d6dc570
12b4457
c843e25
9c81c3e
b1bff5b
d12c4b5
b032a7c
df7c620
c2b17d5
e576c03
490962e
d849664
c49694a
0ccca49
58a5c8b
68194a0
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we should split this discussion into two things: how we detect that R needs installing and how to specify which libraries should be installed.
A more eloquent version of:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd delete this line if we don't want to duplicate the contents of the doc string for the class. Ideally we'd be able to come up with a nice short summary about all the various ways to trigger the R buildpack but I currently can't think of one :-(
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Deleted. Your call, really. I guess the "nice short summary" means it can't be automated.
Do you think there should be a developer-facing variant of the config files docs?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some developer facing docs would be good. Maybe building on https://repo2docker.readthedocs.io/en/latest/architecture.html?