[WIP] add hydroshare as a content provider #766
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@sblack-usu Hi! I've also implemented a content provider and made some changes in the class hierarchy (see #788). Your code needs an update if #788 is merged before this one, and I'm happy to do that while the new developments are still in my head :-). What's your plan regarding the tests? |
|
@nuest - I'll go ahead and update to the new class hierarchy and get the tests in soon. Haven't been able to prioritize this work since I got back from the conference, but will have time this week. |
|
I didn't have time the other week, but I'm working on the tests now, so 🤞 it's enough. |
|
reopening with a new branch |
|
reopened in #800 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://www.hydroshare.org is a data repository for Hydrologists to share water data.
I will add tests soon