[MRG] Add Figshare content provider #788
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moving common functions to a DoiProvider
nuest
force-pushed
the
contentproviders/figshare
branch
from
cb0a46e
to
e6cd4b1
Compare
betatim
reviewed
Sep 8, 2019
betatim
reviewed
Sep 8, 2019
betatim
reviewed
Sep 8, 2019
betatim
approved these changes
Sep 8, 2019
|
Thanks for taking a look so quickly! I will investigate the versioning. |
nuest
changed the title
This was referenced Sep 9, 2019
betatim
reviewed
Sep 9, 2019
|
@betatim |
|
@betatim I think this is ready now, can you take another look, please? |
|
Sure thing! We also change the title from WIP to MRG when it is ready for reviewing (and then maybe merge). MRG is a bit of a misnomer really it is more like "review please and then merge if you are happy" but yeah. |
nuest
changed the title
betatim
reviewed
Sep 11, 2019
| @property | ||
| def content_id(self): | ||
| """The Figshare article ID""" | ||
| return "{}.v{}".format(self.article_id, self.article_version) |
|
Merged! Could you make a PR that adds a line to the change log for this? |
|
Sure (my bad), #792 Also: jupyterhub/binderhub#951 |
markmo
pushed a commit
to markmo/repo2docker
that referenced
this pull request
Jan 22, 2021
[MRG] Add Figshare content provider
markmo
pushed a commit
to markmo/repo2docker
that referenced
this pull request
Jan 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also needs UI update: jupyterhub/binderhub#938