Merge pull request #55 from Zsailer/actions2

Github Actions (round 2)

.github/workflows/linter.yml

@@ -1,4 +1,4 @@
-name: Jupyter Telemetry Unit Tests
+name: Linter
 on:
   push:
     branches: '*'
@@ -7,6 +7,8 @@ on:
 jobs:
   build:
     runs-on: ubuntu-latest
+    strategy:
+      fail-fast: false
     steps:
     - name: Checkout
       uses: actions/checkout@v1

.github/workflows/unittest.yml

@@ -22,7 +22,7 @@ jobs:
         architecture: 'x64'
     - name: Install the Python dependencies
       run: |
-        pip install -r dev-requirements
+        pip install -r dev-requirements.txt
         pip install -e .
     - name: Run the tests
       run: |

README.md

@@ -1,6 +1,6 @@
 # Telemetry
 
-[![CircleCI](https://circleci.com/gh/jupyter/telemetry.svg?style=svg)](https://circleci.com/gh/jupyter/telemetry)
+[![Tests](https://github.com/jupyter/telemetry/workflows/Jupyter%20Telemetry%20Unit%20Tests/badge.svg)](https://github.com/jupyter/telemetry/actions?query=workflow%3A%22Jupyter+Telemetry+Unit+Tests%22)
 [![codecov](https://codecov.io/gh/jupyter/telemetry/branch/master/graph/badge.svg)](https://codecov.io/gh/jupyter/telemetry)
 [![Documentation Status](https://readthedocs.org/projects/jupyter-telemetry/badge/?version=latest)](https://jupyter-telemetry.readthedocs.io/en/latest/?badge=latest)
 

tests/test_register_schema.py

@@ -132,7 +132,7 @@ def test_record_event():
     }
 
 
-def test_register_schema_file():
+def test_register_schema_file(tmp_path):
     """
     Register schema from a file
     """
@@ -150,13 +150,10 @@ def test_register_schema_file():
     el = EventLog()
 
     yaml = YAML(typ='safe')
-    with tempfile.NamedTemporaryFile(mode='w') as f:
-        yaml.dump(schema, f)
-        f.flush()
 
-        f.seek(0)
-
-        el.register_schema_file(f.name)
+    schema_file = tmp_path.joinpath("schema.yml")
+    yaml.dump(schema, schema_file)
+    el.register_schema_file(str(schema_file))
 
     assert schema in el.schemas.values()