Add support for named pipes and sockets #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
takluyver
reviewed
Aug 20, 2017
testpath/asserts.py
Outdated
| raise AssertionError(msg) | ||
|
|
||
| def assert_issocket(path, follow_symlinks=True, msg=None): | ||
| """Assert that path exists and is a named pipe (FIFO). |
There was a problem hiding this comment.
These docstrings should probably say 'Unix domain socket' rather than 'named pipe'.
testpath/asserts.py
Outdated
| """Assert that path exists and is a named pipe (FIFO). | ||
|
|
||
| With follow_symlinks=True, the default, this will pass if path is a symlink | ||
| to a regular file. With follow_symlinks=False, it will fail in that case. |
There was a problem hiding this comment.
'regular file' -> 'named pipe'
Similarly in all four of the new docstrings.
nehaljwani
force-pushed
the
pipes_and_sockets
branch
from
fd0f6c6
to
7cc3233
Compare
|
Thanks! |
|
I've added them to the docs as well: |
|
Ah! A new release already! Cool 👍 |
|
I haven't actually done a release yet - I'll give it a little while in case there's other things to add soon. But I'm pre-emptively marking them as 'new in' to give people reading the docs a hint why those functions aren't there for them. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commits adds asserts for named pipe (FIFO) and socket file types.