This repository has been archived by the owner on Jan 24, 2018. It is now read-only.
Fix cull_max option #262
Merged
Fix cull_max option #262
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Wow, thanks. |
|
Thanks @bryanwweber for the contribution and kind words. We hope to see you around the jupyter and jupyterhub projects with future contributions ;-) Also, your cantera project looks really neat. |
|
@willingc Thanks! This semester and last semester, I've been using Jupyter Notebooks for my classes here at UConn and slowly figuring things out, so I hope to be able to give back soon. |
|
@bryanwweber That's great. As an FYI, there is a Jupyter in Education mailing list/google group (low volume, good content). Good luck with classes and feel free to reach out or say hello on JupyterHub gitter. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that my containers were being culled at one hour, no matter what the cull_max option was set to, and tracked it down to the setting of
max_age(notopts.max_agethough). I also noticed that containers were being added to thestalelist, even if they hadn't been started yet. I'm not sure if this is necessary, but I made it so containers would have to be started before they were added to the list. Finally, I fixed a few typos in README and I just noticed that my editor automatically removed some EOL whitespace. Please let me know if this is useful or not, particularly thestalechange. Thanks for an awesome script!