This repository has been archived by the owner on Jan 24, 2018. It is now read-only.
Add the option for container user in README #267
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I discovered the minergate-cli (cryptocurrency miner) running in one of my tmpnb containers (based on jupyter/docker-stacks datascience-notebook), fully eating all the 16 cores on server. With the recipe in "Quick start" session of README.md it is possible to install and run arbitrary software as root in the container. It is very dangerous, especially if running containers several days...
This can be cured by adding the option --container-user=jovyan to orchestrate.py in the sample command in section "Quick start" as suggested in issue #266. That is the purpose of this PR.