This repository has been archived by the owner on Jan 24, 2018. It is now read-only.
Alternative Dockerfile for alpine:3.5 based image #271
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @misolietavec, This looks good to me. Thanks for leaving the original file too. Happy to merge 🍰 cc/ @rgbkrk. |
|
Thanks for merging @willingc and @misolietavec for sending a PR over. tmpnb is just a service, nothing is intended to extend from the base image for it (as far as I know). The only reason to keep the other images with Debian etc. is to use common layers amongst an overall deployment (the numpy/scipy stack make the discussion here about sizing fairly moot). |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I already use such image and think of it as an alternative to current image based on python:3.4-wheezy (very outdated) or maybe, newer python:3.5-slim. I left original Dockerfile untouched and added Dockerfile-alpine3.5. I do not use requirements.txt. The fixed versions of docker-py, tornado and pytz are installed with pip by RUN in Dockerfile-alpine3.5. It is on Jupyter developers to decide what to do further.
Image misolietavec/tmpnb is available on hub.docker.com, its size is 71.67 MB. It has 26 apk-installed packages and 10 pip-installed, so is certainly not bloated. Issues with busybox - it is included in many well known distributions (Red Hat/Centos, Debian, Arch,...). And musl libc instead of glibc - can someone think of concrete problems in context of tmpnb (or jupyter/configurable-http-proxy) docker images?