Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manual copy of icons to gh-pages #114

Merged
merged 1 commit into from
Dec 6, 2018
Merged

Conversation

dsblank
Copy link
Member

@dsblank dsblank commented Dec 6, 2018

The icons are not being copied to the gh-pages, because I suspect that they are not being processed by R. So we manually copy them in the _deploy.sh script.

@labarba
Copy link
Member

labarba commented Dec 6, 2018

Those icons are all horrendous! Can we replace them for something nice?

@willingc
Copy link
Member

willingc commented Dec 6, 2018

Looking at https://github.com/rstudio/bookdown/tree/gh-pages, it may be better to put these images in a subdirectory in master and then do a pr to gh-pages instead of travis shipping them back and forth.

@willingc
Copy link
Member

willingc commented Dec 6, 2018

And yes we can replace. I think the intent was to use as temporary images @labarba

@dsblank
Copy link
Member Author

dsblank commented Dec 6, 2018

I was just building off what we already have. I thought about what you suggest @willingc .But I like that what we have is complete and self-contained (we can move easily to a different manner of hosting, for example). And if the images are updated in master, we don't have to think about fixing in the deployed version. If we do it piecemeal via PR's then we have to maintain each item through a PR to a separate branch (gh-pages).

In any event, I think we have a solution for the pullouts, although I don't know what they look like in epub. I think we may have to do something specific in epub to get something that looks good.

@willingc
Copy link
Member

willingc commented Dec 6, 2018

@dsblank That's reasonable.

Merging and opening a issue #115 to replace the images with those that are more visually appealing.

Copy link
Member

@willingc willingc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @dsblank

@willingc willingc merged commit dcf93d6 into master Dec 6, 2018
@willingc willingc deleted the dsb-manually-copy-icons branch December 6, 2018 13:03
@dsblank
Copy link
Member Author

dsblank commented Dec 6, 2018

There is a slight issue in referring to the images from the deployed gh-pages. I'm working on it...

@dsblank
Copy link
Member Author

dsblank commented Dec 6, 2018

Fixed in #116 (I think)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants