-
Notifications
You must be signed in to change notification settings - Fork 129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Manual copy of icons to gh-pages #114
Conversation
Those icons are all horrendous! Can we replace them for something nice? |
Looking at https://github.com/rstudio/bookdown/tree/gh-pages, it may be better to put these images in a subdirectory in master and then do a pr to gh-pages instead of travis shipping them back and forth. |
And yes we can replace. I think the intent was to use as temporary images @labarba |
I was just building off what we already have. I thought about what you suggest @willingc .But I like that what we have is complete and self-contained (we can move easily to a different manner of hosting, for example). And if the images are updated in master, we don't have to think about fixing in the deployed version. If we do it piecemeal via PR's then we have to maintain each item through a PR to a separate branch (gh-pages). In any event, I think we have a solution for the pullouts, although I don't know what they look like in epub. I think we may have to do something specific in epub to get something that looks good. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @dsblank
There is a slight issue in referring to the images from the deployed gh-pages. I'm working on it... |
Fixed in #116 (I think) |
The icons are not being copied to the gh-pages, because I suspect that they are not being processed by R. So we manually copy them in the _deploy.sh script.