Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Edge operators #340

Merged
merged 25 commits into from
Mar 29, 2024
Merged

Edge operators #340

merged 25 commits into from
Mar 29, 2024

Conversation

martinRenou
Copy link
Collaborator

@martinRenou martinRenou commented Mar 25, 2024 •
edited
Loading

Add support for:

  • selecting edges
  • apply edge operators: chamfer and fillet
Screencast.from.2024-03-27.11-59-47.webm

@github-actions GitHub Actions
Copy link
Contributor

Binder 👈 Launch a Binder on branch martinRenou/jupytercad/chamfer

@martinRenou martinRenou added the enhancement New feature or request label Mar 25, 2024
@martinRenou martinRenou force-pushed the chamfer branch 12 times, most recently from 22706e5 to 391701c Compare March 27, 2024 11:05
@martinRenou martinRenou changed the title Chamfer operator Edge operators Mar 27, 2024
@martinRenou
Copy link
Collaborator Author

martinRenou commented Mar 27, 2024 •
edited
Loading

please update snapshots!

@martinRenou
Copy link
Collaborator Author

https://github.com/jupytercad/jupytercad/actions/runs/8454362416

@martinRenou martinRenou reopened this Mar 27, 2024
@martinRenou martinRenou reopened this Mar 27, 2024
trungleduc
trungleduc reviewed Mar 28, 2024
View reviewed changes
.eslintrc.js Outdated Show resolved Hide resolved
@martinRenou martinRenou marked this pull request as ready for review March 28, 2024 12:28
martinRenou and others added 20 commits March 29, 2024 11:17
@martinRenou
Working version
1b26ced
@pre-commit-ci @martinRenou
[pre-commit.ci] auto fixes from pre-commit.com hooks
02ae40d 
for more information, see https://pre-commit.ci
@martinRenou
Allow ts-ignore
577898b
@martinRenou
Add fillet symbols
e83af37
@martinRenou
Fillet operator
5954b3a
@pre-commit-ci @martinRenou
[pre-commit.ci] auto fixes from pre-commit.com hooks
d68d14f 
for more information, see https://pre-commit.ci
@martinRenou
Fix object properties panel
2f174b2
@pre-commit-ci @martinRenou
[pre-commit.ci] auto fixes from pre-commit.com hooks
cf05f4e 
for more information, see https://pre-commit.ci
@martinRenou
Fix selection from tree view
1beb798
@martinRenou
Fix visibility toggle
79d1fc7
@martinRenou
Move prop
1d5b75c
@martinRenou
Ease linter
f91b694
@martinRenou
Revert example change
f843556
@github-actions @martinRenou
Update Playwright Snapshots
b31287d
@martinRenou
Slightly smaller lines
f0fdfa0
@github-actions @martinRenou
Update Playwright Snapshots
26c3863
@martinRenou
Fix fillet icon for JupyterLab display
e351345
@martinRenou
Fix chamfer icon for jlab
fdc2eb0
@martinRenou
Use chamfer and fillet icons
271bc70
@martinRenou
Rename Edge::Chamfer to Part::Chamfer
26d5965
@trungleduc
Copy link
Member

Thanks @martinRenou, great work!

@martinRenou martinRenou merged commit c0219d7 into jupytercad:main Mar 29, 2024
9 checks passed
@martinRenou martinRenou deleted the chamfer branch March 29, 2024 11:32
@martinRenou martinRenou mentioned this pull request Mar 29, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trungleduc trungleduc trungleduc approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@martinRenou @trungleduc