New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add request info bot #4
Add request info bot #4
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - one small change
Co-Authored-By: Chris Holdgraf <choldgraf@gmail.com>
Can we make the voice of the bot more prescriptive? Not "we'd appreciate" but "In order for us to be able to review your contribution please describe it in more detail. The most important question to answer in your description is: what goal do you want to achieve with this change?" Being polite but also making it clear that it is rude to open a PR without description and that we won't move until there is one. Also giving users a hint as to what we expect them to do for the cases where they aren't sure what to write. |
you are both better at being assertive than my midwestern self 😆 I like the new language! |
Says the pushy American to the polite Englishman who now lives in subtle Switzerland ;) I like it. merge time? |
LGTM! =) Thanks for working on this, it will be a good improvement to the community experience as a whole I think. |
Should I then send a request to enable the bot in all the repos in the org and not just a few (like we did for the other bot)? |
Done. I think I sent requests for all the repos (it wasn't any confirmation page, so I'm not entirely sure it went through). |
I think it went through - I "accepted" a reviewbot request for the jupyterhub repos...can we test this? |
Closes #2
When no description is provided for a issue/PR, the bot will label the issue with
needs-more-info
and post this message:I couldn't link a PR template because we don't have an organization specific one yet.
Also, the bot doesn't provide any placeholder we can use to get the username of the person opening the issue/pr or the name of the repo.