Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add request info bot #4

Merged
merged 3 commits into from Apr 29, 2020

Conversation

GeorgianaElena
Copy link
Member

Closes #2

When no description is provided for a issue/PR, the bot will label the issue with needs-more-info and post this message:
req-info

I couldn't link a PR template because we don't have an organization specific one yet.
Also, the bot doesn't provide any placeholder we can use to get the username of the person opening the issue/pr or the name of the repo.

.github/config.yml Outdated Show resolved Hide resolved
Copy link
Member

@choldgraf choldgraf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - one small change

Co-Authored-By: Chris Holdgraf <choldgraf@gmail.com>
@betatim
Copy link
Member

betatim commented Apr 29, 2020

Can we make the voice of the bot more prescriptive? Not "we'd appreciate" but "In order for us to be able to review your contribution please describe it in more detail. The most important question to answer in your description is: what goal do you want to achieve with this change?"

Being polite but also making it clear that it is rude to open a PR without description and that we won't move until there is one. Also giving users a hint as to what we expect them to do for the cases where they aren't sure what to write.

@GeorgianaElena
Copy link
Member Author

Being polite but also making it clear that it is rude to open a PR without description and that we won't move until there is one. Also giving users a hint as to what we expect them to do for the cases where they aren't sure what to write.

Agree!

How does this new message sound?
new-bot-message

@choldgraf
Copy link
Member

you are both better at being assertive than my midwestern self 😆 I like the new language!

@betatim
Copy link
Member

betatim commented Apr 29, 2020

Says the pushy American to the polite Englishman who now lives in subtle Switzerland ;)

I like it. merge time?

@consideRatio consideRatio merged commit cefd40d into jupyterhub:master Apr 29, 2020
@consideRatio
Copy link
Member

LGTM! =) Thanks for working on this, it will be a good improvement to the community experience as a whole I think.

@GeorgianaElena
Copy link
Member Author

Should I then send a request to enable the bot in all the repos in the org and not just a few (like we did for the other bot)?

@GeorgianaElena
Copy link
Member Author

Done. I think I sent requests for all the repos (it wasn't any confirmation page, so I'm not entirely sure it went through).

@GeorgianaElena GeorgianaElena deleted the request_info_bot branch April 30, 2020 06:03
@choldgraf
Copy link
Member

I think it went through - I "accepted" a reviewbot request for the jupyterhub repos...can we test this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adding the Request Info bot
4 participants