Environment handling refactoring. #119
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Rework req_keepvars. Old meaning of req_keepvars didn't make sense,
because it overrode mandatory variables that JupyterHub sets.
Change to these two variables:
- req_keepvars_default: Automatically set by JupyterHub defaults,
should not be overridden. Old req_keepvars becomes this. Should
only be changed if you know what you are doing.
- req_keepvars: Adds to the defaults in req_keepvars_default. This
is what cluster admins usually want to set.
- This is environment which is intended to be passed only to the batch commands, not to the user servers. However, it is unknown if any spawners support this. Don't rely on it unless the spawner explicitely says it supports it.
rkdarst
force-pushed
the
keepvars_refactor
branch
from
786f903
to
705bcf8
Compare
- This fixes up all the previous commits on this branch
rkdarst
force-pushed
the
keepvars_refactor
branch
from
705bcf8
to
88f6523
Compare
|
thanks, in the next 2-3 weeks I am deploying a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
req_keepvarsimplies that it is for setting environment variables - but to use it, you have to re-add all of the JH defaults. This is not very intuitive, and makes it not very useful.Rename
req_keepvarstoreq_keepvars_default- this is pre-filled by default with the output fromjupyterhub.spawner.Spawner.get_env()which is the environment that JH thinks that singleuser servers need.Add a new
req_keepvarswhich gets added toreq_keepvars_defaultto become the actualreq_keepvarsin the batch script. This and previous would probably have helped with #118,Add a new
admin_environmentwhich is added to the environment for running the commands, but not the--export={keepvars}in the scripts. This can be used to authenticate to batch systems in something as an admin. Note that it is not yet guaranteed that this works in all spawners.Any thoughts on these?
All together these help with #82, considering security.