Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update batchspawner.py to use --chdir instead of --workdir #165

Merged
merged 1 commit into from Jul 23, 2020

Conversation

yfoo
Copy link
Contributor

@yfoo yfoo commented Oct 25, 2019

Switched --workdir in the slurm section to be --chdir instead. Slurm 19.05 series removed the --workdir option.

Switched --workdir in the slurm section to be --chdir instead. Slurm 19.05 series removed the --workdir option.
@rkdarst
Copy link
Contributor

rkdarst commented Jun 30, 2020

Looks good, in Slurm since 17.11 so that's not very old but not too new either. I tried to add a changelog entry, but could'nt push to here. I'll add it in my upcoming integration branch. Thanks!

This was referenced Jul 23, 2020
@mbmilligan mbmilligan merged commit 81c5f21 into jupyterhub:master Jul 23, 2020
@welcome
Copy link

welcome bot commented Jul 23, 2020

Congrats on your first merged pull request in this project! 🎉
congrats
Thank you for contributing, we are very proud of you! ❤️

mbmilligan added a commit that referenced this pull request Jul 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants