Skip to content

Commit

Permalink
set cookie secret unconditionally
Browse files Browse the repository at this point in the history
no reason to leave it undefined, even if we don't use it
  • Loading branch information
minrk committed May 6, 2024
1 parent 7a9d4ba commit 6fa1f1b
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions binderhub/app.py
Original file line number Diff line number Diff line change
Expand Up @@ -962,8 +962,7 @@ def initialize(self, *args, **kwargs):
"enable_api_only_mode": self.enable_api_only_mode,
}
)
if self.auth_enabled:
self.tornado_settings["cookie_secret"] = os.urandom(32)
self.tornado_settings["cookie_secret"] = os.urandom(32)
if self.cors_allow_origin:
self.tornado_settings.setdefault("headers", {})[
"Access-Control-Allow-Origin"
Expand Down

0 comments on commit 6fa1f1b

Please sign in to comment.