Fix registry <-> push_secret config interaction

jupyterhub · Dec 30, 2022 · 8a48dac · 8a48dac
1 parent 451059c
commit 8a48dac
Showing 1 changed file with 3 additions and 5 deletions.
diff --git a/binderhub/builder.py b/binderhub/builder.py
@@ -437,11 +437,6 @@ async def get(self, provider_prefix, _unescaped_spec):
         # Prepare to build
         q = Queue()
 
-        # if self.settings["use_registry"] or self.settings["build_docker_config"]:
-        #     push_secret = self.settings["push_secret"]
-        # else:
-        #     push_secret = None
-
         BuildClass = self.settings.get("build_class")
 
         build = BuildClass(
@@ -454,6 +449,9 @@ async def get(self, provider_prefix, _unescaped_spec):
             image_name=image_name,
             git_credentials=provider.git_credentials,
         )
+        if not self.settings["use_registry"]:
+            build.push_secret = ""
+
         self.build = build
 
         with BUILDS_INPROGRESS.track_inprogress():