Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix chart publishing workflow #1213

Merged
merged 1 commit into from
Nov 15, 2020

Conversation

consideRatio
Copy link
Member

@consideRatio consideRatio commented Nov 13, 2020

Followup of #1209 and #1212 with, hopefully, final fix.

@@ -6,6 +6,7 @@
# Exit on errors, assert env vars, log commands
set -eux

cd helm-chart
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the change that fixes the problem. The other two changes are clean up/prettiness only.

@betatim betatim merged commit e6cfbd6 into jupyterhub:master Nov 15, 2020
consideRatio pushed a commit to jupyterhub/helm-chart that referenced this pull request Nov 15, 2020
jupyterhub/binderhub#1213 Merge pull request #1213 from consideRatio/pr/fix-gha-publish-2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants