-
Notifications
You must be signed in to change notification settings - Fork 382
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
breaking: start require k8s 1.20+ and test against k8s 1.20 and latest #1493
breaking: start require k8s 1.20+ and test against k8s 1.20 and latest #1493
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks ok to me, but I will leave a more "official" approval to someone with a little more context. I am unsure about the implications of this on the federation.
Main determinant is whether all members are running at least K8s 1.20. If they are this should be fine to merge and deploy. Might be nice to include the K8S version in Lines 236 to 254 in 656204b
|
All the members are good atm, I'm not sure about gesis though, but if gesis is at 1.19 or older it makes sense to error if time is used to update the binderhub helm chart rather than the k8s cluster's version. Turing: v1.21 With this, I'll move onwards. |
jupyterhub/binderhub#1493 Merge pull request #1493 from consideRatio/pr/req-k8s-1.20-and-test-against-latest-k3s
GESIS is still at v1.19 (I will update it ASAP) but interestingly the upgrade went through to the latest release ( |
@MridulS oh, that is very weird. What version of the @MridulS btw, also note that there is a lot of misc changes of relevance to make to unstuck from old k8s versions and old helm chart dependencies. These are mentioned in jupyterhub/mybinder.org-deploy#2182. With regards to upgrading your k8s version, I think you should upgrade to k8s 1.21, but no further at this point, because of the migration steps needed to be done first in the issue linked above. I think we are stuck at k8s 1.21 now to support the mybinder helm chart. But, it would be good if you are at 1.21 like most others at that point in time. |
helm is at Thanks for the heads up! I will update the cluster to v1.21 then :) |
Is the mybinder.org federation beyond k8s 1.19 at this point?
Z2JH requires k8s 1.20 currently, see jupyterhub/zero-to-jupyterhub-k8s#2635. @manics made a great job documenting the status of various cloud providers in jupyterhub/zero-to-jupyterhub-k8s#2591 (comment). In short, k8s 1.19 is not supported by Google, Amazon, or Azure.
While we could wait to bump this until we run into a need raise the lower level, I'd prefer to not wait. If we realize there is a need to raise the lower lever, then suddenly the person fixing something ends up needing to side-track and do this breaking change first before etc. In other words, by doing this now, we avoid slowing down and blocking something else when we really need to do it.