breaking: require Python 3.8, from Python 3.6 #1610
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
consideRatio
commented
Jan 4, 2023
consideRatio
commented
- breaking: require Python 3.8, from Python 3.6
- pre-commit: run with pyupgrade --py38-plus
|
Do you mind adding this breaking change to https://github.com/jupyterhub/binderhub/blob/main/CHANGES.md#breaking-changes ? |
|
On second thoughts, let's leave the breaking changes doc till after all these breaking PRs are merged to avoid dealing with conflicts.... just need to remember 😄 (edit: didn't realise pasting a URL to a label displays the label in-line!) |
manics
approved these changes
Jan 4, 2023
Yepp I was thinking the same thing! Thanks for your review!! |
consideRatio
pushed a commit
to jupyterhub/helm-chart
that referenced
this pull request
Jan 4, 2023
jupyterhub/binderhub#1610 Merge pull request #1610 from consideRatio/pr/require-py38
|
Hello! Just FYI now that 3.6 is no longer supported Hatchling can be used as the build backend. cc @blink1073 to confirm |
|
Yes, that is true, using |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.