ci: set GITHUB_ACCESS_TOKEN to temporary read only token #1612
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The token provided by secrets.github_token in github workflows does not have permissions to work against the api.github.com/gists endpoint.
consideRatio
force-pushed
the
pr/attempt-fix-github-ratelimit
branch
from
9b36832
to
44260da
Compare
betatim
approved these changes
Jan 5, 2023
|
I started looking last night, saw a massive JSON blob.... and decided to leave it 😄. Everything else looked fine though, so happy to go with @betatim |
|
Ah sorry about the JSON blob. I wrote about it but then felt my PR description ended up so long that it was boring to read through and removed my notes about it ^^ The JSON changes is two keys representing api.github.com/gists URLs that are to be mocked that I relocated from one file to a standalone file. In other words, its just one file split in two. Thanks for reviewing this, I'll go for a merge! |
consideRatio
pushed a commit
to jupyterhub/helm-chart
that referenced
this pull request
Jan 5, 2023
jupyterhub/binderhub#1612 Merge pull request #1612 from consideRatio/pr/attempt-fix-github-ratelimit
|
I spotted a typo in this PR so the issue wasn't resolved. I added a commit fixing that typo in #1615 now though. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We ran into rate limitations, but by setting the env var
GITHUB_ACCESS_TOKENin our GitHub Job's, which is the default value forc.GitHubRepoProvider.access_token, this is no longer an issue.We still have to mock tests with GistRepoProvider as the
secrets.github_tokenis not provided rights to access api.github.com/gists.Remaining test failure is resolved by #1615