Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow building the image without needing to launch it #1647

Merged
merged 48 commits into from
Oct 10, 2023
Merged

Allow building the image without needing to launch it #1647

merged 48 commits into from
Oct 10, 2023

Commits on Sep 20, 2023

  1. Empty dummy commit to allow a draft PR to be created

    @consideRatio @GeorgianaElena
    consideRatio authored and GeorgianaElena committed Sep 20, 2023
    Configuration menu
    Copy the full SHA
    a5a13ec View commit details
    Browse the repository at this point in the history

  2. Add the traitlet option and check query param with same name

    @GeorgianaElena
    GeorgianaElena committed Sep 20, 2023
    Configuration menu
    Copy the full SHA
    bb910cd View commit details
    Browse the repository at this point in the history

  3. Update api exaple to support option

    @GeorgianaElena
    GeorgianaElena committed Sep 20, 2023
    Configuration menu
    Copy the full SHA
    2ed3e8b View commit details
    Browse the repository at this point in the history

  4. No need for fstrings

    @GeorgianaElena
    GeorgianaElena committed Sep 20, 2023
    Configuration menu
    Copy the full SHA
    4a11638 View commit details
    Browse the repository at this point in the history

  5. Try out a test

    @GeorgianaElena
    GeorgianaElena committed Sep 20, 2023
    Configuration menu
    Copy the full SHA
    008cc34 View commit details
    Browse the repository at this point in the history

  6. Update messages emmited

    @GeorgianaElena
    GeorgianaElena committed Sep 20, 2023
    Configuration menu
    Copy the full SHA
    3505fcb View commit details
    Browse the repository at this point in the history

  7. Use the ready phase to signal end of ops

    @GeorgianaElena
    GeorgianaElena committed Sep 20, 2023
    Configuration menu
    Copy the full SHA
    5ec3c5a View commit details
    Browse the repository at this point in the history

  8. Make the no_launch option configurable

    @GeorgianaElena
    GeorgianaElena committed Sep 20, 2023
    Configuration menu
    Copy the full SHA
    bc8f68c View commit details
    Browse the repository at this point in the history

  9. Add no_launch to local testing config

    @GeorgianaElena
    GeorgianaElena committed Sep 20, 2023
    Configuration menu
    Copy the full SHA
    5987b4e View commit details
    Browse the repository at this point in the history

  10. Rename configs and change logic

    @GeorgianaElena
    GeorgianaElena committed Sep 20, 2023
    Configuration menu
    Copy the full SHA
    dc9b84b View commit details
    Browse the repository at this point in the history

  11. Change error type

    @GeorgianaElena
    GeorgianaElena committed Sep 20, 2023
    Configuration menu
    Copy the full SHA
    835a43b View commit details
    Browse the repository at this point in the history

  12. Update examples

    @GeorgianaElena
    GeorgianaElena committed Sep 20, 2023
    Configuration menu
    Copy the full SHA
    fbdf0c6 View commit details
    Browse the repository at this point in the history

  13. Update initial test

    @GeorgianaElena
    GeorgianaElena committed Sep 20, 2023
    Configuration menu
    Copy the full SHA
    3c310e9 View commit details
    Browse the repository at this point in the history

  14. Remove unused import

    @GeorgianaElena
    GeorgianaElena committed Sep 20, 2023
    Configuration menu
    Copy the full SHA
    27c2944 View commit details
    Browse the repository at this point in the history

  15. Update messages and logic to preserve old ones but also be explicit a… 

    …bout new options
    @GeorgianaElena
    GeorgianaElena committed Sep 20, 2023
    Configuration menu
    Copy the full SHA
    0aff6a8 View commit details
    Browse the repository at this point in the history

  16. Update one more message

    @GeorgianaElena
    GeorgianaElena committed Sep 20, 2023
    Configuration menu
    Copy the full SHA
    e67a84b View commit details
    Browse the repository at this point in the history

  17. Add more test for failing cases

    @GeorgianaElena
    GeorgianaElena committed Sep 20, 2023
    Configuration menu
    Copy the full SHA
    b80eaf7 View commit details
    Browse the repository at this point in the history

  18. Add missing config

    @GeorgianaElena
    GeorgianaElena committed Sep 20, 2023
    Configuration menu
    Copy the full SHA
    97cabe3 View commit details
    Browse the repository at this point in the history

  19. Test with build_only true

    @GeorgianaElena
    GeorgianaElena committed Sep 20, 2023
    Configuration menu
    Copy the full SHA
    0edd782 View commit details
    Browse the repository at this point in the history

  20. Allow for build_only configured app fixture in all kind of tests

    @GeorgianaElena
    GeorgianaElena committed Sep 20, 2023
    Configuration menu
    Copy the full SHA
    7f5156b View commit details
    Browse the repository at this point in the history

  21. Do not mark tests remote as we cannot configure binderhub with the de… 

    …sired config
    @GeorgianaElena
    GeorgianaElena committed Sep 20, 2023
    Configuration menu
    Copy the full SHA
    dabfb6d View commit details
    Browse the repository at this point in the history

  22. _binderhub_config fixture has a session scope

    @GeorgianaElena
    GeorgianaElena committed Sep 20, 2023
    Configuration menu
    Copy the full SHA
    1f4db5f View commit details
    Browse the repository at this point in the history

  23. Add more comments and do some cleanup

    @GeorgianaElena
    GeorgianaElena committed Sep 20, 2023
    Configuration menu
    Copy the full SHA
    2f0e3ce View commit details
    Browse the repository at this point in the history

  24. [pre-commit.ci] auto fixes from pre-commit.com hooks 

    for more information, see https://pre-commit.ci
    @pre-commit-ci @GeorgianaElena
    pre-commit-ci[bot] authored and GeorgianaElena committed Sep 20, 2023
    Configuration menu
    Copy the full SHA
    09da08d View commit details
    Browse the repository at this point in the history

  25. Only test one situation as running this test is toily 

    Co-authored-by: Erik Sundell <erik.i.sundell@gmail.com>
    @GeorgianaElena @consideRatio
    GeorgianaElena and consideRatio committed Sep 20, 2023
    Configuration menu
    Copy the full SHA
    3a43d8e View commit details
    Browse the repository at this point in the history

  26. Put the fixtures back into the tests as they're needed

    @GeorgianaElena
    GeorgianaElena committed Sep 20, 2023
    Configuration menu
    Copy the full SHA
    ff0670c View commit details
    Browse the repository at this point in the history

  27. Move logic about determining the build only action into its own function

    @GeorgianaElena
    GeorgianaElena committed Sep 20, 2023
    Configuration menu
    Copy the full SHA
    fc84a66 View commit details
    Browse the repository at this point in the history

  28. Move the eval table to the tratilet help string

    @GeorgianaElena
    GeorgianaElena committed Sep 20, 2023
    Configuration menu
    Copy the full SHA
    fb008c8 View commit details
    Browse the repository at this point in the history

  29. [pre-commit.ci] auto fixes from pre-commit.com hooks 

    for more information, see https://pre-commit.ci
    @pre-commit-ci @GeorgianaElena
    pre-commit-ci[bot] authored and GeorgianaElena committed Sep 20, 2023
    Configuration menu
    Copy the full SHA
    19d45bd View commit details
    Browse the repository at this point in the history

  30. Add note about not supporting build only UI|

    @GeorgianaElena
    GeorgianaElena committed Sep 20, 2023
    Configuration menu
    Copy the full SHA
    96188ed View commit details
    Browse the repository at this point in the history

  31. Add fixtture to ensure no builds are tried when not available

    @GeorgianaElena
    GeorgianaElena committed Sep 20, 2023
    Configuration menu
    Copy the full SHA
    f53636a View commit details
    Browse the repository at this point in the history

  32. Render an error page when the build UI is accesed and require_build_o… 

    …nly is True
    @GeorgianaElena
    GeorgianaElena committed Sep 20, 2023
    Configuration menu
    Copy the full SHA
    702c57a View commit details
    Browse the repository at this point in the history

  33. [pre-commit.ci] auto fixes from pre-commit.com hooks 

    for more information, see https://pre-commit.ci
    @pre-commit-ci @GeorgianaElena
    pre-commit-ci[bot] authored and GeorgianaElena committed Sep 20, 2023
    Configuration menu
    Copy the full SHA
    a7d2418 View commit details
    Browse the repository at this point in the history

  34. Just deactivate the / and /v2 endpoints when require_build_only is True

    @GeorgianaElena
    GeorgianaElena committed Sep 20, 2023
    Configuration menu
    Copy the full SHA
    252987c View commit details
    Browse the repository at this point in the history

  35. [pre-commit.ci] auto fixes from pre-commit.com hooks 

    for more information, see https://pre-commit.ci
    @pre-commit-ci @GeorgianaElena
    pre-commit-ci[bot] authored and GeorgianaElena committed Sep 20, 2023
    Configuration menu
    Copy the full SHA
    0203a2d View commit details
    Browse the repository at this point in the history

  36. Update build success metrics even if we don't launch after

    @GeorgianaElena
    GeorgianaElena committed Sep 20, 2023
    Configuration menu
    Copy the full SHA
    15dc9d3 View commit details
    Browse the repository at this point in the history

  37. [pre-commit.ci] auto fixes from pre-commit.com hooks 

    for more information, see https://pre-commit.ci
    @pre-commit-ci @GeorgianaElena
    pre-commit-ci[bot] authored and GeorgianaElena committed Sep 20, 2023
    Configuration menu
    Copy the full SHA
    f3d174b View commit details
    Browse the repository at this point in the history

  38. Fix indentation

    @GeorgianaElena
    GeorgianaElena committed Sep 20, 2023
    Configuration menu
    Copy the full SHA
    c20ca53 View commit details
    Browse the repository at this point in the history

Commits on Sep 21, 2023

  1. Replace require_build_only for a more clear enable_api_only_mode config

    @GeorgianaElena
    GeorgianaElena committed Sep 21, 2023
    Configuration menu
    Copy the full SHA
    f7a4c3c View commit details
    Browse the repository at this point in the history

  2. Update how we decide if build only mode was activated

    @GeorgianaElena
    GeorgianaElena committed Sep 21, 2023
    Configuration menu
    Copy the full SHA
    5cf641d View commit details
    Browse the repository at this point in the history

  3. Get the Custom404 handler in both cases

    @GeorgianaElena
    GeorgianaElena committed Sep 21, 2023
    Configuration menu
    Copy the full SHA
    61d1a5d View commit details
    Browse the repository at this point in the history

  4. update message

    @GeorgianaElena
    GeorgianaElena committed Sep 21, 2023
    Configuration menu
    Copy the full SHA
    08d4f1d View commit details
    Browse the repository at this point in the history

  5. Update the test config

    @GeorgianaElena
    GeorgianaElena committed Sep 21, 2023
    Configuration menu
    Copy the full SHA
    368cad7 View commit details
    Browse the repository at this point in the history

  6. Update tests

    @GeorgianaElena
    GeorgianaElena committed Sep 21, 2023
    Configuration menu
    Copy the full SHA
    693baf9 View commit details
    Browse the repository at this point in the history

  7. [pre-commit.ci] auto fixes from pre-commit.com hooks 

    for more information, see https://pre-commit.ci
    @pre-commit-ci
    pre-commit-ci[bot] committed Sep 21, 2023
    Configuration menu
    Copy the full SHA
    b2925dc View commit details
    Browse the repository at this point in the history

Commits on Sep 22, 2023

  1. Updat log message and assert

    @GeorgianaElena
    GeorgianaElena committed Sep 22, 2023
    Configuration menu
    Copy the full SHA
    6252eb6 View commit details
    Browse the repository at this point in the history

Commits on Oct 10, 2023

  1. Drop the outcome suffix for clariry and specify a status code for the… 

    … http error

Co-authored-by: Min RK <benjaminrk@gmail.com>
    @GeorgianaElena @minrk
    GeorgianaElena and minrk committed Oct 10, 2023
    Configuration menu
    Copy the full SHA
    114b195 View commit details
    Browse the repository at this point in the history

  2. [pre-commit.ci] auto fixes from pre-commit.com hooks 

    for more information, see https://pre-commit.ci
    @pre-commit-ci
    pre-commit-ci[bot] committed Oct 10, 2023
    Configuration menu
    Copy the full SHA
    d5f686d View commit details
    Browse the repository at this point in the history