Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: fix watch-dependencies workflow so it bumps docker and podman images #1665

Merged
merged 2 commits into from
Apr 27, 2023

Conversation

consideRatio
Copy link
Member

@consideRatio consideRatio commented Apr 26, 2023

I figure I'd fix the non-functional automation to bump these instead.

ci-binderhub

@consideRatio consideRatio changed the title Update container-builder docker/podman images ci: fix watch-dependencies workflow so it bumps docker and podman images Apr 26, 2023
run: git --no-pager diff --color=always

# ref: https://github.com/peter-evans/create-pull-request
- name: Create a PR
if: steps.local.outputs.tag != steps.latest.outputs.tag
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A PR won't be created if there isn't a change anyhow, so the check steps.local.outputs.tag != steps.latest.outputs.tag doesn't matter.

@consideRatio
Copy link
Member Author

@manics I reworked this to be fixing the CI workflow watching these dependencies instead.

@consideRatio consideRatio merged commit 2631d73 into jupyterhub:main Apr 27, 2023
15 checks passed
@consideRatio
Copy link
Member Author

Going for a merge as this is CI only and I've tested it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants