maint: fix broken test by upgrading to non-deprecated ruamel.yaml syntax #1702
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
consideRatio
commented
May 22, 2023
•
consideRatio
commented
- Closes ci: indentation failure - why!? #1701
consideRatio
changed the title
consideRatio
commented
May 22, 2023
| @@ -10,7 +10,9 @@ import sys | |||
| from subprocess import check_call | |||
| from tempfile import NamedTemporaryFile | |||
|
|
|||
| from ruamel import yaml | |||
There was a problem hiding this comment.
This was deprecated syntax on how to use ruamel.yaml, and transitioning away from it like done elsewhere solved the issue.
consideRatio
pushed a commit
to jupyterhub/helm-chart
that referenced
this pull request
May 22, 2023
jupyterhub/binderhub#1702 Merge pull request #1702 from consideRatio/pr/fix-ruamel-yaml-syntax-issue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.