Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade pip, setuptools, requirements on travis; switch to pytest-asyncio #768

Merged
merged 5 commits into from
Jan 15, 2019

Conversation

minrk
Copy link
Member

@minrk minrk commented Jan 14, 2019

  • upgrading pip ensures we get warnings about incompatibilities
  • upgrading requirements fixes one such incompatibility with pytest-cov and pytest being too old
  • switch to pytest-asyncio because upgrading pytest breaks pytest-tornado, which is ~unmaintained and has issues with recent pytest and tornado

This should fix recent travis failures

pytest-tornado is unmaintained and has compatibility issues with recent tornado, pytest
needed to avoid UNIQUE CONSTRAINT errors since we run multiple processes
@minrk minrk changed the title upgrade pip, setuptools, requirements on travis upgrade pip, setuptools, requirements on travis; switch to pytest-asyncio Jan 14, 2019
@betatim betatim merged commit 7eb80f1 into jupyterhub:master Jan 15, 2019
yuvipanda pushed a commit to jupyterhub/helm-chart that referenced this pull request Jan 15, 2019
@choldgraf choldgraf added the maintenance Under the hood improvements and fixes label Oct 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Under the hood improvements and fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants