Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs link in building page #781

Merged
merged 2 commits into from
Feb 4, 2019
Merged

Conversation

choldgraf
Copy link
Member

@choldgraf choldgraf commented Jan 30, 2019

This PR adds a short sentence w/ a link to the Binder documentation from the loading page. Many BinderHub users (particularly new ones) will first experience Binder by clicking a link, not from going to mybinder.org. This makes sure that we show them a link to the docs on the loading page itself.

It should look like this when loading:

chrome_2019-01-30_11-00-19

@@ -13,6 +13,9 @@
<div id="loader-text">
<p>Loading your Binder...</p>
</div>
<div id="loader-links">
<p class="text-center">New to Binder? Check out the <a target="_blank" href="https://mybinder.readthedocs.io/en/latest/">Binder Documentation</a> for more information</p>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<p class="text-center">New to Binder? Check out the <a target="_blank" href="https://mybinder.readthedocs.io/en/latest/">Binder Documentation</a> for more information</p>
<p class="text-center">New to Binder? Check out the <a target="_blank" href="https://mybinder.readthedocs.io/en/latest/">Binder Documentation (opens in new window)</a> for more information</p>

What is the current UX recommendation about target=_blank? Personally I find it annoying when sites force me to open something in a new tab, as I am perfectly able to click "open in new tab" when I mean to do that. I can see that for new users it would be good to open it in a new window by default though maybe "new" in this context isn't new to binder but new to using browsers?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The main reason I did it here was because this is a temporary "loading" screen. So in a sense we know what users are expecting: they're expecting to be taken to a running Binder. But if they get redirected to a new page first, then that will never happen.

@betatim
Copy link
Member

betatim commented Feb 3, 2019

(restarted the build, it was a timeout error)

@choldgraf
Copy link
Member Author

looks like travis is happy now, LMK what you think about the target=blank thing...I am not super opinionated on that one

@betatim betatim merged commit a41b5db into jupyterhub:master Feb 4, 2019
@betatim
Copy link
Member

betatim commented Feb 4, 2019

Merged. We can tune this if we hear about people ranting about it online.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants