relax default liveness probe to 10s #790
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
in case something is being bogged down, 1s may not be enough
|
Merged this despite travis failures as I don't think any of our tests would notice if this was wrong. Deploying this once the image is ready to improve mybinder.org. |
yuvipanda
pushed a commit
to jupyterhub/helm-chart
that referenced
this pull request
Feb 14, 2019
yuvipanda
pushed a commit
to jupyterhub/helm-chart
that referenced
this pull request
Feb 14, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in case something is being bogged down, 1s may not be enough
mybinder.org failed liveness probes this morning, despite being fully responsive. Possible due to this being a too-short timeout.